Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(portable-text-editor): implement isSelectionOverlapping method #5870

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feat(portable-text-editor): implement isSelectionOverlapping method #5870

merged 2 commits into from
Feb 28, 2024

Conversation

hermanwikner
Copy link
Member

Description

This pull request introduces an isSelectionOverlapping method to the Portable Text Editor, enabling the check for overlap between two selections.

const isOverlapping = PortableTextEditor.isSelectionOverlapping(editor, selectionA, selectionB)

What to review

  • Make sure that it works as expected

Notes for release

N/A

@hermanwikner hermanwikner requested review from a team and sjelfull and removed request for a team February 28, 2024 11:42
@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 28, 2024 0:23am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 0:23am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 0:23am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

Package Documentation Change
@sanity/diff -18%
Full Report
@sanity/migrate
This branch Next branch
17 documented 17 documented
71 not documented 59 not documented
sanity
This branch Next branch
179 documented 179 documented
847 not documented 860 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/types
This branch Next branch
55 documented 55 documented
233 not documented 239 not documented
sanity/desk
This branch Next branch
84 documented 84 documented
64 not documented 64 not documented
@sanity/portable-text-editor
This branch Next branch
21 documented 21 documented
44 not documented 44 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
3 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
31 not documented 31 not documented
sanity/structure
This branch Next branch
2 documented 2 documented
8 not documented 8 not documented
@sanity/util/concurrency-limiter
This branch Next branch
1 documented 1 documented
0 not documented 0 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
4 not documented 5 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
12 not documented 12 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
17 documented 17 documented
26 not documented 26 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/client
This branch Next branch
1 documented 1 documented
0 not documented 0 not documented
@sanity/util/createSafeJsonParser
This branch Next branch
1 documented 1 documented
0 not documented 0 not documented
sanity/_internalBrowser
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented
@sanity/diff
This branch Next branch
13 documented 16 documented
16 not documented 13 not documented

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

Component Testing Report Updated Feb 28, 2024 12:27 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 2s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@hermanwikner hermanwikner force-pushed the feat/pte-overlapping-method branch from efc5348 to 0eaebb1 Compare February 28, 2024 12:06
skogsmaskin
skogsmaskin approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And thanks for the test 👍

@hermanwikner hermanwikner force-pushed the feat/pte-overlapping-method branch from 0eaebb1 to 262d8c8 Compare February 28, 2024 12:18
@hermanwikner hermanwikner added this pull request to the merge queue Feb 28, 2024
Merged via the queue into next with commit 1d41af7 Feb 28, 2024
19 of 21 checks passed
@hermanwikner hermanwikner deleted the feat/pte-overlapping-method branch February 28, 2024 12:20
@Cdaprod Cdaprod mentioned this pull request Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skogsmaskin skogsmaskin skogsmaskin approved these changes

@sjelfull sjelfull Awaiting requested review from sjelfull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hermanwikner @skogsmaskin